[webkit-reviews] review requested: [Bug 99842] Touch operation corrupts screen when specifying other than overflow:visible in css : [Attachment 183879] The modified patch to fix buildbot warning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 20:34:13 PST 2013


Hideki <yoshida-hxa at necst.nec.co.jp> has asked	for review:
Bug 99842: Touch operation corrupts screen when specifying other than
overflow:visible in css
https://bugs.webkit.org/show_bug.cgi?id=99842

Attachment 183879: The modified patch to fix buildbot warning
https://bugs.webkit.org/attachment.cgi?id=183879&action=review

------- Additional Comments from Hideki <yoshida-hxa at necst.nec.co.jp>
buildbot warns about "RenderLayer::ScrollOffsetClamping::ScrollOffsetClamped"
Here is the message.
 warning C4482: nonstandard extension used: enum
'WebCore::RenderLayer::ScrollOffsetClamping' used in qualified name

C4482 warning is described as following.

// C4482.cpp
// compile with: /c /W1
struct S {
   enum E { a };
};

int i = S::E::a;   // C4482
int j = S::a;	// OK

So I have replaced
 "RenderLayer::ScrollOffsetClamping::ScrollOffsetClamped"
with
 "RenderLayer::ScrollOffsetClamped"


More information about the webkit-reviews mailing list