[webkit-reviews] review denied: [Bug 107488] Whitelist should also work for the WebVTT ::cue element without an argument : [Attachment 183867] Proposed fix 0.4

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has denied Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 107488: Whitelist should also work for the WebVTT ::cue element without an
argument
https://bugs.webkit.org/show_bug.cgi?id=107488

Attachment 183867: Proposed fix 0.4
https://bugs.webkit.org/attachment.cgi?id=183867&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183867&action=review


> Source/WebCore/css/RuleSet.cpp:125
> -	   if (component->pseudoType() == CSSSelector::PseudoCue)
> +	   if (component->pseudoType() == CSSSelector::PseudoCue ||
selector->value() == TextTrackCue::cueShadowPseudoId())

This looks wrong. If 'component' has (m_match == CSSSelector::Tag), value()
should not be called as it will perform an incorrect cast.
In fact, CSSSelector::value() should ASSERT(m_match != Tag), just like
CSSSelector::tagQName() asserts the opposite.