[webkit-reviews] review granted: [Bug 107488] Whitelist should also work for the WebVTT ::cue element without an argument : [Attachment 183863] Proposed fix 0.2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 21 18:20:50 PST 2013
Darin Adler <darin at apple.com> has granted Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 107488: Whitelist should also work for the WebVTT ::cue element without an
argument
https://bugs.webkit.org/show_bug.cgi?id=107488
Attachment 183863: Proposed fix 0.2
https://bugs.webkit.org/attachment.cgi?id=183863&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183863&action=review
> LayoutTests/media/track/track-css-property-whitelist.html:35
> cueNode = skipNonElements(textTrackDisplayElement(video,
'all-nodes').firstChild);
This should just use firstElementChild instead.
> Source/WebCore/css/RuleSet.cpp:49
> #include <wtf/MemoryInstrumentationVector.h>
> +#if ENABLE(VIDEO_TRACK)
Need a space before this #if line.
> Source/WebCore/css/RuleSet.cpp:129
> +>>>>>>> whitelist2
Need to delete this.
More information about the webkit-reviews
mailing list