[webkit-reviews] review denied: [Bug 100399] [CSS Exclusions] shape-outside on floats for rectangle shapes positioning : [Attachment 183814] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Bem Jones-Bey <bjonesbe at adobe.com>'s
request for review:
Bug 100399: [CSS Exclusions] shape-outside on floats for rectangle shapes
positioning
https://bugs.webkit.org/show_bug.cgi?id=100399

Attachment 183814: Patch
https://bugs.webkit.org/attachment.cgi?id=183814&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183814&action=review


r-

> Source/WebCore/rendering/RenderBlock.h:696
> +    enum FloatRenderingState { FloatLayout, FloatPaint };

I wouldn't describe this as layout vs. painting. I'd just be more explicit
about the math, since really it's kind of a hack that painting does this double
subtraction at all. We just need to re-architect paint at some point to get rid
of it.

I'd just make the enum something like IncludeChildCoordinates vs.
DoNotIncludeChildCoordinates. :)