[webkit-reviews] review denied: [Bug 107363] [EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL : [Attachment 183626] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 12:24:08 PST 2013


Benjamin Poulain <benjamin at webkit.org> has denied Sudarsana Nagineni (babu)
<naginenis at gmail.com>'s request for review:
Bug 107363: [EFL][WK2] Implement WebInspector::localizedStringsURL() on EFL
https://bugs.webkit.org/show_bug.cgi?id=107363

Attachment 183626: patch
https://bugs.webkit.org/attachment.cgi?id=183626&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183626&action=review


> Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp:43
> +    StringBuilder builder;
> +    builder.appendLiteral("file://");
> +    builder.append(WebCore::inspectorResourcePath());
> +    builder.appendLiteral("/localizedStrings.js");
> +
> +    return builder.toString();

This should be using the String Operators, not String builder.


More information about the webkit-reviews mailing list