[webkit-reviews] review granted: [Bug 107460] Move HTML Attribute case-sensitivity logic out of SelectorChecker to HTMLDocument. : [Attachment 183803] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 107460: Move HTML Attribute case-sensitivity logic out of SelectorChecker
to HTMLDocument.
https://bugs.webkit.org/show_bug.cgi?id=107460

Attachment 183803: Patch
https://bugs.webkit.org/attachment.cgi?id=183803&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183803&action=review


This is no longer inline, but I doubt it matters. The more I look at style
resolve perf the more I realize its the tree walk which is so expensive (that,
and a few super hot functions, like cansharestylewith)

> Source/WebCore/html/HTMLDocument.cpp:344
> +    HashSet<AtomicStringImpl*>* attrSet = new HashSet<AtomicStringImpl*>;

I don't think this needs to be atomicstringimpl anymore. That was an old
limitation of our collection classes, but now we have traits for atomicstring. 
I also don't think it hurts to use impl either. :-)