[webkit-reviews] review denied: [Bug 85755] [CSS3 Values] Add support for the "ch" unit : [Attachment 183785] CSS3 ch unit patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 10:43:15 PST 2013


Dave Hyatt <hyatt at apple.com> has denied Lamarque V. Souza
<Lamarque.Souza at basyskom.com>'s request for review:
Bug 85755: [CSS3 Values] Add support for the "ch" unit
https://bugs.webkit.org/show_bug.cgi?id=85755

Attachment 183785: CSS3 ch unit patch
https://bugs.webkit.org/attachment.cgi?id=183785&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I would prefer that the zero width get put into the font metrics (similar to
what we do with other size information like xheight). That way
computeLengthDouble is consistent across all unit types in that it talks to the
font metrics for this sort of information.


More information about the webkit-reviews mailing list