[webkit-reviews] review granted: [Bug 105436] [GTK][AC] setOpacity doesn't work for GraphicsLayerClutter : [Attachment 180758] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 10:31:11 PST 2013


Gustavo Noronha (kov) <gns at gnome.org> has granted ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 105436: [GTK][AC] setOpacity doesn't work for GraphicsLayerClutter
https://bugs.webkit.org/show_bug.cgi?id=105436

Attachment 180758: Patch
https://bugs.webkit.org/attachment.cgi?id=180758&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=180758&action=review


> Source/WebCore/ChangeLog:9
> +	   Added GraphicsLayerClutter::setOpacity & other stuff. Most codes to
set opacity
> +	   to GraphicsLayerClutter are taken from mac port.

'& other stuff' doesn't add anything, maybe say 'and wire it to the layer sync
mechanism.'? Also I'd say "Based on Mac's GraphicsLayer implementation" instead
of the other sentence.


More information about the webkit-reviews mailing list