[webkit-reviews] review denied: [Bug 107449] [Qt][WK1] Web Notifications : [Attachment 183782] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 107449: [Qt][WK1] Web Notifications
https://bugs.webkit.org/show_bug.cgi?id=107449

Attachment 183782: Patch
https://bugs.webkit.org/attachment.cgi?id=183782&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183782&action=review


r-ing until we agree on the dumpNotification part.

> Source/WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:-361
> -    m_cachedPermissions.remove(context);
> -

Could you explain why this line isn't needed, in the changelog?

> Tools/DumpRenderTree/qt/TestRunnerQt.cpp:-48
> -    DumpRenderTreeSupportQt::dumpNotification(true);

If we remove this, it would be better to remove all the code that this
triggered in NotificationPresenterClientQt.cpp and all test expected files that
relied on this.
Could this be done in a different patch as well?