[webkit-reviews] review granted: [Bug 107438] [Qt][WK1] Permission request callbacks for non-legacy notifications : [Attachment 183756] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 21 06:17:07 PST 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted  review:
Bug 107438: [Qt][WK1] Permission request callbacks for non-legacy notifications
https://bugs.webkit.org/show_bug.cgi?id=107438

Attachment 183756: Patch
https://bugs.webkit.org/attachment.cgi?id=183756&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
Humm, it doesn't look as good as I thought, so we might as well duplicate the
code.
- NotificationPermissionCallback is defined behind ENABLE(NOTIFICATIONS)
- Adding to a different list depending on the callback type isn't great

r+ing the first one


More information about the webkit-reviews mailing list