[webkit-reviews] review denied: [Bug 107433] Web Inspector: fix highlight bug in DTE. : [Attachment 183742] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 107433: Web Inspector: fix highlight bug in DTE.
https://bugs.webkit.org/show_bug.cgi?id=107433

Attachment 183742: Patch
https://bugs.webkit.org/attachment.cgi?id=183742&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183742&action=review


> Source/WebCore/ChangeLog:8
> +	   Fix highlight bug related to highlightChunkLimit in
DefaultTextEditor.

You should explain what has changed and why

> Source/WebCore/inspector/front-end/TextEditorHighlighter.js:188
> +		   } else {

What if there is no midConditionStringified? Will you hit NPE at
state.ranges.push?

no {} around single line blocks. Why creating ranges early