[webkit-reviews] review granted: [Bug 107382] Make SpeechSynthesis compile in the Chromium port : [Attachment 183687] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 20 21:47:14 PST 2013


Adam Barth <abarth at webkit.org> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 107382: Make SpeechSynthesis compile in the Chromium port
https://bugs.webkit.org/show_bug.cgi?id=107382

Attachment 183687: Patch
https://bugs.webkit.org/attachment.cgi?id=183687&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
IMHO, this stub file is fine given that it's just fixing the compile.  We
should refactor both the Chromium and Mac versions of this file before adding
any actual code to either of them, however.

Sam is likely also asking for an extra layer of abstraction so that
SpeechSynthesis.cpp can be implemented in terms of a common WebCore/platform
API that's agnostic as to which platform backend is actually implementing the
synthesis.


More information about the webkit-reviews mailing list