[webkit-reviews] review granted: [Bug 107266] [chromium] move speech related methods to TestRunner library : [Attachment 183663] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 107266: [chromium] move speech related methods to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=107266

Attachment 183663: Patch
https://bugs.webkit.org/attachment.cgi?id=183663&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183663&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:110
> +#if ENABLE(INPUT_SPEECH)

We don't usually put ENABLE macros in public header files.  The consumers of
these headers on the Chromium side won't know what features are enabled.