[webkit-reviews] review granted: [Bug 107253] [V8] Create a persistent wrapper for Window.prototype and innerGlobalObject : [Attachment 183419] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 107253: [V8] Create a persistent wrapper for Window.prototype and
innerGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=107253

Attachment 183419: Patch
https://bugs.webkit.org/attachment.cgi?id=183419&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch looks harmless.  Setting the class ID should be fine given that we
set native info on these wrappers.  Storing these objects in the DOMDataStore
should be harmless, but also pretty useless.  No one should be looking for them
in the DOMDataStore because we have a custom implementation of toV8 for
DOMWindow.

The only weird thing about storing them in the DOMDataStore is that we'll get a
collision because we'll have three all stored in the HashMap under the key
|window|.  There's nothing really wrong with that (especially since the last
one to be written will basically kick the other ones out), but it's just a
weird case.  I guess we're trading one weird case for another.

I don't think this patch will cause any trouble, but I'm not sure it's really
making things better either.