[webkit-reviews] review granted: [Bug 107382] Make SpeechSynthesis compile in the Chromium port : [Attachment 183635] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 107382: Make SpeechSynthesis compile in the Chromium port
https://bugs.webkit.org/show_bug.cgi?id=107382

Attachment 183635: Patch
https://bugs.webkit.org/attachment.cgi?id=183635&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183635&action=review


> Source/WebCore/Modules/speech/chromium/SpeechSynthesisChromium.cpp:48
> +}

i think we'll be able to move some of these calls into the SpeechSynthesis.h
(i've done that in my latest patch), but I can move that around as needed

> Source/WebCore/WebCore.gypi:901
> +	       'Modules/speech/DOMWindowSpeechSynthesis.cpp',

this might not be in alpha order

> Source/WebKit/chromium/features.gypi:110
> +	 'ENABLE_SPEECH_SYNTHESIS=0',

looks like this is not in alpha order. should be after enable_smooth