[webkit-reviews] review granted: [Bug 106986] Get WTF compiling in VS2010 (32bit) : [Attachment 183638] WTF property sheets and project files

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 106986: Get WTF compiling in VS2010 (32bit)
https://bugs.webkit.org/show_bug.cgi?id=106986

Attachment 183638: WTF property sheets and project files
https://bugs.webkit.org/attachment.cgi?id=183638&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183638&action=review


Rubber-stamp is the best I can do here.

Also, what's with the couple garbage bytes at the beginning of lots of the
generated files?

> WTF.vcproj/WTF.sln:5
> -Microsoft Visual Studio Solution File, Format Version 9.00
> -# Visual Studio 2005
> -Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WTFGenerated",
"WTFGenerated.vcproj", "{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}"
> +Microsoft Visual Studio Solution File, Format Version 11.00
> +# Visual Studio 2010
> +Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "WTFGenerated",
"WTFGenerated.vcxproj", "{5AE5F5E4-782D-4F63-B4D7-3977B52B9950}"
>  EndProject

Did you mean to upgrade the toplevel solution?

> WTF2010.vcproj/work-around-vs-dependency-tracking-bugs.py:27
> +    # Visual Studio isn't smart enough to figure out it needs to rebuild
these file types when
> +    # .vsprops files change (even if we touch wtf/Platform.h below), so we
delete them to force them
> +    # to be rebuilt.

Is this still true?

> config.h:41
>  #ifndef _WIN32_WINNT
> -#define _WIN32_WINNT 0x0500
> +#define _WIN32_WINNT 0x0501
>  #endif
>  
>  #ifndef WINVER
> -#define WINVER 0x0500
> +#define WINVER 0x0501
>  #endif

What is going on here? I see that 0x0501 is Windows XP... what was 0x0500?