[webkit-reviews] review denied: [Bug 106188] Proposal: Add support for even-odd fill and clip to Canvas : [Attachment 183496] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 106188: Proposal: Add support for even-odd fill and clip to Canvas
https://bugs.webkit.org/show_bug.cgi?id=106188

Attachment 183496: Patch
https://bugs.webkit.org/attachment.cgi?id=183496&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183496&action=review


Looks good. Just some snippets. Code and tests look great! r- since you are not
committer yet. I would also like to wait for possible responses on webkit-dev
before giving my final OK.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.h:287
> +    

remove white spaces here please.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.idl:26
> +// FIXME: use CanvasWindingRule once support for WebIDL is completed

A real sentence please. We have a bug report for that. Can you link to this
(need to search it)?

> LayoutTests/ChangeLog:36
> +2013-01-17  Rik Cabanier  <cabanier at adobe.com>
> +
> +	   Proposal: Add support for even-odd fill and clip to Canvas
> +	   https://bugs.webkit.org/show_bug.cgi?id=106188
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add tests to verify that the winding rule work as expected with
clip, fill and isPointInPath
> +
> +	   * fast/canvas/canvas-clip-rule-expected.txt: Added.
> +	   * fast/canvas/canvas-clip-rule.html: Added.
> +	   * fast/canvas/canvas-fill-rule-expected.txt: Added.

This is a duplicate. Please remove it.