[webkit-reviews] review granted: [Bug 107373] Clean up missing *explicit* keyword in ctors of WebCore/rendering : [Attachment 183621] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 19 08:21:58 PST 2013


Darin Adler <darin at apple.com> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 107373: Clean up missing *explicit* keyword in ctors of WebCore/rendering
https://bugs.webkit.org/show_bug.cgi?id=107373

Attachment 183621: Patch
https://bugs.webkit.org/attachment.cgi?id=183621&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is OK, but the patch has minimal benefit. There is near zero risk of
accidentally doing implicit construction of these classes from these pointer
types. Just no real chance this will arise idiomatically. Except maybe
RenderArena.


More information about the webkit-reviews mailing list