[webkit-reviews] review granted: [Bug 107362] [WK2] Remove obsolete plug-in sandboxing code : [Attachment 183607] regenerated the patch with a saved ChangeLog

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 107362: [WK2] Remove obsolete plug-in sandboxing code
https://bugs.webkit.org/show_bug.cgi?id=107362

Attachment 183607: regenerated the patch with a saved ChangeLog
https://bugs.webkit.org/attachment.cgi?id=183607&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183607&action=review


> Source/WebKit2/PluginProcess/mac/PluginProcessMac.mm:328
> -    RetainPtr<NSString> profileString = [[NSString alloc]
initWithContentsOfURL:(NSURL *)sandboxURL.get() encoding:NSUTF8StringEncoding
error:NULL];
> +    RetainPtr<NSString> profileString = adoptNS([[NSString alloc]
initWithContentsOfURL:(NSURL *)sandboxURL.get() encoding:NSUTF8StringEncoding
error:NULL]);
>      if (!profileString)
>	   return;
>  
> -    enterSandbox([profileString.get() UTF8String], 0, 0);
> +    enterSandbox([profileString.get() UTF8String]);

Seems crazy to decode UTF-8 then re-encode as UTF8. If we want to use
initWIthContentsOfURL: then I think we should use the one on NSData, not
NSString, here.