[webkit-reviews] review denied: [Bug 106860] Split SelectorChecker's fast-checking logic into its own class. : [Attachment 183599] Awesome.

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 106860: Split SelectorChecker's fast-checking logic into its own class.
https://bugs.webkit.org/show_bug.cgi?id=106860

Attachment 183599: Awesome.
https://bugs.webkit.org/attachment.cgi?id=183599&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=183599&action=review


Looks pretty good. Please hold this until kling gets his complicated
CSSSelector changes in though.

> Source/WebCore/css/FastPathSelectorMatcher.h:39
> +    FastPathSelectorMatcher(CSSSelector*, Element*);

I think the naming should be consistent with SelectorChecker. I'd also prefer
prefix style naming for subsystems. This one could be SelectorCheckerFastPath.
What do you think?

> Source/WebCore/css/FastPathSelectorMatcher.h:45
> +    static bool canUseFastPath(const CSSSelector*);

FastPath is redundant.