[webkit-reviews] review granted: [Bug 107080] Remove a TextTrack.h include from the Element.h and move WebVTT related stuff outside the Element : [Attachment 183590] Proposed fix 0.2

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dima Gorbik <dgorbik at apple.com>'s
request for review:
Bug 107080: Remove a TextTrack.h include from the Element.h and move WebVTT
related stuff outside the Element
https://bugs.webkit.org/show_bug.cgi?id=107080

Attachment 183590: Proposed fix 0.2
https://bugs.webkit.org/attachment.cgi?id=183590&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183590&action=review


> Source/WebCore/html/track/WebVTTElement.h:32
> +enum WebVTTNodeType {

This should probably be WebVTTElementType, no?

> Source/WebCore/html/track/WebVTTElement.h:48
> +    WebVTTElement(const QualifiedName& tagName, Document*);

No need for tagName here.  This should probably be private.

> Source/WebCore/html/track/WebVTTElement.h:56
> +: HTMLElement(tagName, document)
> +, m_webVTTNodeType(WebVTTNodeTypeNone)

These should be indented.  Does this need to be in the header?

> Source/WebCore/html/track/WebVTTElement.h:60
> +inline WebVTTElement* toWebVTTElement(Node* node)

You should probably also add a 

// This will catch anyone doing an unnecessary cast.
void toWebVTTElement(const WebVTTElement*); 

without an implementation.