[webkit-reviews] review denied: [Bug 106946] Sticky-position elements can jump around/hide on rubber-banding : [Attachment 183585] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 18:01:19 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 106946: Sticky-position elements can jump around/hide on rubber-banding
https://bugs.webkit.org/show_bug.cgi?id=106946

Attachment 183585: Patch
https://bugs.webkit.org/attachment.cgi?id=183585&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183585&action=review


> Source/WebCore/rendering/RenderBoxModelObject.cpp:513
>      LayoutRect viewportRect = view()->frameView()->visibleContentRect();
> +   
viewportRect.setLocation(toPoint(view()->frameView()->scrollOffsetForFixedPosit
ion()));

We do this in so many places that I think it's time to add something to
FrameView for this. Maybe viewportConstrainedObjectRect() ?


More information about the webkit-reviews mailing list