[webkit-reviews] review granted: [Bug 102828] r134080 causes heap problem on linux systems where PAGESIZE != 4096 : [Attachment 183513] Make capacity field static.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 11:28:16 PST 2013


Mark Hahnenberg <mhahnenberg at apple.com> has granted Balazs Kilvady
<kilvadyb at homejinni.com>'s request for review:
Bug 102828: r134080 causes heap problem on linux systems where PAGESIZE != 4096
https://bugs.webkit.org/show_bug.cgi?id=102828

Attachment 183513: Make capacity field static.
https://bugs.webkit.org/attachment.cgi?id=183513&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183513&action=review


r=me with small edit and no EWS issues.

> Source/JavaScriptCore/heap/MarkStack.h:79
>      static size_t sizeFromCapacity(size_t capacity)

One more change. Remove this function, since nobody calls it.


More information about the webkit-reviews mailing list