[webkit-reviews] review granted: [Bug 106474] [CSS Grid Layout] Add support for min-content : [Attachment 183340] Proposed implementation 4: Updated after Ojan & Tony's comments.

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 106474: [CSS Grid Layout] Add support for min-content
https://bugs.webkit.org/show_bug.cgi?id=106474

Attachment 183340: Proposed implementation 4: Updated after Ojan & Tony's
comments.
https://bugs.webkit.org/attachment.cgi?id=183340&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183340&action=review


> Source/WebCore/rendering/RenderGrid.cpp:205
> +    ASSERT(trackLength.isMinContent() || trackLength.isMaxContent() ||
trackLength.isAuto());

Can it not be fit-content, fill-available, etc?

> Source/WebCore/rendering/RenderGrid.cpp:229
> +    if (direction == ForColumns)
> +	   return child->minPreferredLogicalWidth();

Nit: would be prefer to see a FIXME here to track whether this should return
the preferred width or the intrinsic width.