[webkit-reviews] review granted: [Bug 107042] AX: Improve table-guessing heuristics : [Attachment 183311] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 107042: AX: Improve table-guessing heuristics
https://bugs.webkit.org/show_bug.cgi?id=107042

Attachment 183311: Patch
https://bugs.webkit.org/attachment.cgi?id=183311&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183311&action=review


> Source/WebCore/accessibility/AccessibilityTable.cpp:151
> +    // if there are at least 20 rows, we'll call it a data table

Full sentence with capitalization and period.

> Source/WebCore/accessibility/AccessibilityTable.cpp:223
> +	       // also keep track of each individual border, so we can catch
tables where most

ditto for the comments

> LayoutTests/accessibility/table-detection.html:67
> +	   This should not be a table because cells have the same  colors even
though there is spacing

extra space between same and colors. might as well fix it now

> LayoutTests/accessibility/table-detection.html:192
> +	   This should be a table because it has a col

remember to end sentences with a period