[webkit-reviews] review granted: [Bug 106792] Text Autosizing: don't autosize headers with multiple inline links. : [Attachment 183479] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted
timvolodine at chromium.org's request for review:
Bug 106792: Text Autosizing: don't autosize headers with multiple inline links.
https://bugs.webkit.org/show_bug.cgi?id=106792

Attachment 183479: Patch
https://bugs.webkit.org/attachment.cgi?id=183479&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183479&action=review


> Source/WebCore/rendering/TextAutosizer.cpp:310
> +    //  1. it should not contain non-link text elements longer than 3
characters

it would be nice to know where these heuristics come from, like mention it in
the changelog

> Source/WebCore/rendering/TextAutosizer.cpp:312
> +    //  2. it should contain at least 3 inline links, and all the links
should
> +    //     have the same specified font size

2. it should consist of min. 3 inline links using the same specified font size.


> Source/WebCore/rendering/TextAutosizer.cpp:335
> +	       else
> +		   if (matchingFontSize !=
renderer->style()->specifiedFontSize())
> +		       return false;
> +

This else needs braces according to style as it is spanning multiple actual
code lines, not logical ones