[webkit-reviews] review requested: [Bug 107131] [GTK] Implement testRunner::setTextDirection : [Attachment 183480] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 09:14:14 PST 2013


Manuel Rego Casasnovas <rego at igalia.com> has asked  for review:
Bug 107131: [GTK] Implement testRunner::setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=107131

Attachment 183480: Patch
https://bugs.webkit.org/attachment.cgi?id=183480&action=review

------- Additional Comments from Manuel Rego Casasnovas <rego at igalia.com>
Fixed style in method. Avoid name for gpointer param as it's not used.
Specified name for GtkTextDirection as previousDirection gives interesting
information as someone could confuse it with current direction.


More information about the webkit-reviews mailing list