[webkit-reviews] review granted: [Bug 107280] Web Inspector: [Canvas] add getResourceInfo and getResourceState methods to the protocol : [Attachment 183452] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 107280: Web Inspector: [Canvas] add getResourceInfo and getResourceState
methods to the protocol
https://bugs.webkit.org/show_bug.cgi?id=107280

Attachment 183452: Patch
https://bugs.webkit.org/attachment.cgi?id=183452&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183452&action=review


> Source/WebCore/inspector/InjectedScriptCanvasModule.cpp:158
> +void InjectedScriptCanvasModule::resourceInfo(ErrorString* errorString,
const String& resourceId, RefPtr<TypeBuilder::Canvas::ResourceInfo>* result)

getResourceInfo (since you use output parameter).

> Source/WebCore/inspector/InjectedScriptCanvasModule.cpp:172
> +void InjectedScriptCanvasModule::resourceState(ErrorString* errorString,
const String& traceLogId, const String& resourceId,
RefPtr<TypeBuilder::Canvas::ResourceState>* result)

ditto

> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:2972
> +	* @param {string} traceLogId

CanvasAgent.TraceLogId

> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:3011
> +	   return {

I'd introduce a small wrapper that goes into runtime cast.

> Source/WebCore/inspector/InjectedScriptCanvasModuleSource.js:3069
> +	* @return {!Object}

@return {{id:string,...

> Source/WebCore/inspector/Inspector.json:3215
> +		       { "name": "dataURL", "type": "string", "optional": true,
"description": "Screenshot data URL." }

imageURL