[webkit-reviews] review denied: [Bug 106878] [EFL][Qt][WebGL] Avoid deleting an uncreated canvas. : [Attachment 183449] patchv7

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 106878: [EFL][Qt][WebGL] Avoid deleting an uncreated canvas.
https://bugs.webkit.org/show_bug.cgi?id=106878

Attachment 183449: patchv7
https://bugs.webkit.org/attachment.cgi?id=183449&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183449&action=review


> Source/WebKit2/ChangeLog:11
> +	   is later used to either create or delete the canvas. The issue seems

> +	   to be that we mark a canvas for deletion even though it has not

"seems" that doesn't make me confident in the patch

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:333
> +	   if (!platformLayer) {
> +	       m_canvasState |= DestroyCanvas;
> +	       m_canvasState &= ~CreateCanvas;

this sounds more like a pending operation to me than a state

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
h:174
> +    enum CanvasState {
> +	   CreateCanvas = 0x01,
> +	   ValidCanvas = 0x02,
> +	   DestroyCanvas = 0x04,
> +	   RecreateCanvas = CreateCanvas | DestroyCanvas
> +    };

This seems a bit confusing to me... like mixing "create" with "valid"