[webkit-reviews] review denied: [Bug 107131] [GTK] Implement testRunner::setTextDirection : [Attachment 183443] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 107131: [GTK] Implement testRunner::setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=107131

Attachment 183443: Patch
https://bugs.webkit.org/attachment.cgi?id=183443&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=183443&action=review


LGTM, just a couple of nitpicks!

> Source/WebKit/gtk/webkit/webkitwebview.cpp:272
> +static void webkit_web_view_direction_changed(WebKitWebView* webView,
GtkTextDirection previousDirection, gpointer gpointer);

gpointer gpointer? I guess something like data would be better

> Source/WebKit/gtk/webkit/webkitwebview.cpp:5367
> +void webkit_web_view_direction_changed(WebKitWebView* webView,
GtkTextDirection previousDirection, gpointer gpointer)

Well since the gpointer is not used you can omit to name it in the function
signature.