[webkit-reviews] review denied: [Bug 107263] Web Inspector: Allow SplitView to change orientation after the construction : [Attachment 183429] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vladislav Kaznacheev
<kaznacheev at chromium.org>'s request for review:
Bug 107263: Web Inspector: Allow SplitView to change orientation after the
construction
https://bugs.webkit.org/show_bug.cgi?id=107263

Attachment 183429: Patch
https://bugs.webkit.org/attachment.cgi?id=183429&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183429&action=review


Few nits and it is good to go.

> Source/WebCore/inspector/front-end/SplitView.js:45
>      this._firstElement = document.createElement("div");

this._firstElement = this.element.createChild("div", "split-view-contents");

will do the same.

> Source/WebCore/inspector/front-end/SplitView.js:50
> +    this._secondElement.className = "split-view-contents";

ditto

> Source/WebCore/inspector/front-end/SplitView.js:54
> +    this._resizerElement.className = "split-view-resizer";

ditto

> Source/WebCore/inspector/front-end/SplitView.js:81
> +    setIsVertical: function(isVertical)

setVertical

> Source/WebCore/inspector/front-end/SplitView.js:95
> +    _innerSetIsVertical: function(isVertical)

_innerSetVertical

> Source/WebCore/inspector/front-end/SplitView.js:281
> +    _updateTotalSize: function() {

{ on the next line

> Source/WebCore/inspector/front-end/SplitView.js:295
> +	   this._resizerElement.style.removeProperty("left");

This might look better as a part of removeAllLayoutProperties

> Source/WebCore/inspector/front-end/SplitView.js:396
> +    _onDragStart: function(event) {

{ on the next line

> Source/WebCore/inspector/front-end/SplitView.js:405
> +	 if (!this._sidebarSizeSettingName)

4 space indent please

> Source/WebCore/inspector/front-end/SplitView.js:421
> +	   return (sizeSetting ? sizeSetting.get() : 0 ) || (this._isVertical ?
this._savedSidebarWidth : this._savedSidebarHeight);

no space after 0, please split this into two lines?

> Source/WebCore/inspector/front-end/SplitView.js:430
> +	       this._savedSidebarWidth = size;

It is unfortunate split is now Width/Height aware, but I don't see a way to
make it simpler. Maintaining both settings at all times and making settingName
required is probably a good thing that will save on some lines here as well.