[webkit-reviews] review denied: [Bug 107232] Web Inspector: make sure InspectorInstrumentationCookie is invalidated if inspected page was destroyed : [Attachment 183399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 18 01:31:48 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 107232: Web Inspector: make sure InspectorInstrumentationCookie is
invalidated if inspected page was destroyed
https://bugs.webkit.org/show_bug.cgi?id=107232

Attachment 183399: Patch
https://bugs.webkit.org/attachment.cgi?id=183399&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183399&action=review


> Source/WebCore/inspector/InspectorInstrumentation.h:98
> +    RefPtr<InstrumentingAgents> instrumentingAgents;

You should encapsulate these and introduce hasAgents() and hasMatchingId(int)
methods.


More information about the webkit-reviews mailing list