[webkit-reviews] review granted: [Bug 107227] Fix WTF::copyLCharsFromUCharSource() to compile with -Wshorten-64-to-32 : [Attachment 183376] Patch v2

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 107227: Fix WTF::copyLCharsFromUCharSource() to compile with
-Wshorten-64-to-32
https://bugs.webkit.org/show_bug.cgi?id=107227

Attachment 183376: Patch v2
https://bugs.webkit.org/attachment.cgi?id=183376&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183376&action=review


> Source/WTF/wtf/text/ASCIIFastPath.h:115
>      const uintptr_t sourceLoadSize = 32; // Process 32 bytes (16 UChars)
each iteration
> -    const unsigned ucharsPerLoop = sourceLoadSize / sizeof(UChar);
> +    const size_t ucharsPerLoop = sourceLoadSize / sizeof(UChar);

You may want to change sourceLoadSize to size_t for the case where
sizeof(size_t) < sizeof(void*)