[webkit-reviews] review denied: [Bug 106878] [EFL][Qt][WebGL] Avoid deleting an uncreated canvas. : [Attachment 183296] patchv6

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Kalyan
<kalyan.kondapally at intel.com>'s request for review:
Bug 106878: [EFL][Qt][WebGL] Avoid deleting an uncreated canvas.
https://bugs.webkit.org/show_bug.cgi?id=106878

Attachment 183296: patchv6
https://bugs.webkit.org/attachment.cgi?id=183296&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183296&action=review


Better but you still have an unused variable without the USE()

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
cpp:127
> +    , m_canvasState(0)

This should be in a #ifdef block for USE(GRAPHICS_SURFACE)

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.
h:256
> +    unsigned m_canvasState;

This should be in the block USE(GRAPHICS_SURFACE) above.