[webkit-reviews] review granted: [Bug 107180] Flakiness dashboard: Add ChromiumFYI master : [Attachment 183286] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted  review:
Bug 107180: Flakiness dashboard: Add ChromiumFYI master
https://bugs.webkit.org/show_bug.cgi?id=107180

Attachment 183286: Patch
https://bugs.webkit.org/attachment.cgi?id=183286&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183286&action=review


>>> Tools/TestResultServer/static-dashboards/builders.jsonp:-1137
>>> -		 "dromaeo_domcoreattr_test": {
>> 
>> This isn't right. I think there's a bug in the script where we don't detect
if a bot is in a broken state. Looks like these bots were hitting a python
exception earlier today. Please rerun the script and upload new results.
> 
> I don't understand. These are perf tests, and there's no test type in
dashboard for these. Also, if these derived from step names, there's no step
with this name:
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Perf/builds/4131
> There's one without _test suffix. I ran generate_builders_json.py several
times.

Oh. Good point. I got this confused with the perf dashboard, which does use
these builders.