[webkit-reviews] review granted: [Bug 106429] webkitpy's SCM unit tests fail : [Attachment 183099] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 106429: webkitpy's SCM unit tests fail
https://bugs.webkit.org/show_bug.cgi?id=106429

Attachment 183099: Patch
https://bugs.webkit.org/attachment.cgi?id=183099&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183099&action=review


OK.

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:129
> +	   executive = executive or Executive()

This is still a FIXME, but way better, thank you!

> Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:1551
> +    maxDiff = None

Was this intentional?