[webkit-reviews] review denied: [Bug 107171] Add Android-specific EditingBehavior : [Attachment 183268] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied  review:
Bug 107171: Add Android-specific EditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=107171

Attachment 183268: Patch
https://bugs.webkit.org/attachment.cgi?id=183268&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183268&action=review


I'm sorry but I have to r- this.

> Source/WebCore/ChangeLog:11
> +	   On Android, EditingBehavior::shouldMoveCaret[...] controls the
> +	   behavior of insertion handles. This change adds a new Android
specific
> +	   editing behavior type so that we can change these settings
independent
> +	   of behavior for other platforms.

I don't think adding a new editing behavior makes sense here. r-.
The only reason we decided to have these editing behaviors is so that we can
test these behaviors in layout tests.
Given that we're not doing it, ifdef will suffice.

> Source/WebCore/editing/EditingBehavior.h:71
> -	   return m_type == EditingUnixBehavior;
> +	   return m_type == EditingUnixBehavior || m_type ==
EditingAndroidBehavior;

This code is never used in Android port.