[webkit-reviews] review granted: [Bug 107171] Add Android-specific EditingBehavior : [Attachment 183268] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 13:56:46 PST 2013


Levi Weintraub <leviw at chromium.org> has granted Chris Hopman
<cjhopman at chromium.org>'s request for review:
Bug 107171: Add Android-specific EditingBehavior
https://bugs.webkit.org/show_bug.cgi?id=107171

Attachment 183268: Patch
https://bugs.webkit.org/attachment.cgi?id=183268&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183268&action=review


r=me

> Source/WebCore/ChangeLog:13
> +	   No new tests (OOPS!).

You'll have to change this. You can't lande with "OOPS!" in the ChangeLog.
Ideally you should add a test that verifies this behavior, but I'd be content
with an explanation of why you're not adding one.


More information about the webkit-reviews mailing list