[webkit-reviews] review denied: [Bug 106589] [chromium] Use new-style gesture scrolling events for fling. : [Attachment 183233] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 12:38:36 PST 2013


James Robinson <jamesr at chromium.org> has denied Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 106589: [chromium] Use new-style gesture scrolling events for fling.
https://bugs.webkit.org/show_bug.cgi?id=106589

Attachment 183233: Patch
https://bugs.webkit.org/attachment.cgi?id=183233&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183233&action=review


> Source/WebKit/chromium/src/WebPluginContainerImpl.cpp:799
> +	   ScrollbarGroup* scroller = scrollbarGroup();

if you read the ::scrollbarGroup() you'll see that it constructs a group if one
isn't already there.  You don't want this function to create a new scrollbar
group!	Just check m_scrollbarGroup


More information about the webkit-reviews mailing list