[webkit-reviews] review denied: [Bug 106964] Add Chrome on Android instrumentation test types to flakiness dashboard : [Attachment 183229] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Frank Farzan <frankf at chromium.org>'s
request for review:
Bug 106964: Add Chrome on Android instrumentation test types to flakiness
dashboard
https://bugs.webkit.org/show_bug.cgi?id=106964

Attachment 183229: Patch
https://bugs.webkit.org/attachment.cgi?id=183229&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183229&action=review


> Tools/ChangeLog:16
> +

Nit: extra line break.

> Tools/TestResultServer/generate_builders_json.py:108
> +	   {'name': 'ChromiumFYI', 'url':
'http://build.chromium.org/p/chromium.fyi'},

As discussed offline, lets move this to a separate patch and update jsonp in
that patch as well.

> Tools/TestResultServer/static-dashboards/builders.js:246
> +	   // We don't have tests on ToT, but this must be included

This should be:
// FIXME: We don't have tests...

Ideally you'd also file a bug and list it in this comment. CC me and
jparent at chromium.org.