[webkit-reviews] review denied: [Bug 106874] LongPress should start drag&drop draggable elements in iframes : [Attachment 182898] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has denied yongsheng
<yongsheng.zhu at intel.com>'s request for review:
Bug 106874: LongPress should start drag&drop draggable elements in iframes
https://bugs.webkit.org/show_bug.cgi?id=106874

Attachment 182898: Patch
https://bugs.webkit.org/attachment.cgi?id=182898&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182898&action=review


r- to get one further test running.

> Source/WebCore/page/EventHandler.cpp:2552
> +	   RefPtr<Frame> subframe = subframeForHitTestResult(mev);
> +	   if (subframe && !m_mouseDownMayStartDrag) {
> +	       subframe->eventHandler()->handleDrag(mev,
DontCheckDragHysteresis);
> +	       if (subframe->eventHandler()->didStartDrag())
> +		   return true;
> +	   }

can I assume that it works for nested inner frames?

if we have 3 levels (mainframe, middle frame and inner frame), and the deeper
one handles Drag. Does it work? If so, please add a test.