[webkit-reviews] review canceled: [Bug 96272] NPN_InitializeVariantWithStringCopy is wrong for platforms that return NULL from malloc(0) : [Attachment 163142] NPN_InitializeVariantWithStringCopy patch (2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 03:11:38 PST 2013


Julien Brianceau <jbrianceau at nds.com> has canceled Julien Brianceau
<jbrianceau at nds.com>'s request for review:
Bug 96272: NPN_InitializeVariantWithStringCopy is wrong for platforms that
return NULL from malloc(0)
https://bugs.webkit.org/show_bug.cgi?id=96272

Attachment 163142: NPN_InitializeVariantWithStringCopy patch (2)
https://bugs.webkit.org/attachment.cgi?id=163142&action=review

------- Additional Comments from Julien Brianceau <jbrianceau at nds.com>
Ok, I'll provide a new patch to use fastMalloc allocator for NPN objects and
string variants, and perform few tests.
But I see that even fastMalloc can return 0 when USE_SYSTEM_MALLOC define is
set in Source/WTF/wtf/Platform.h. Should we handle this case ?


More information about the webkit-reviews mailing list