[webkit-reviews] review granted: [Bug 107102] Web Inspector: add createOption method to WebInspector.StatusBarComboBox : [Attachment 183137] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 107102: Web Inspector: add createOption method to
WebInspector.StatusBarComboBox
https://bugs.webkit.org/show_bug.cgi?id=107102

Attachment 183137: Patch
https://bugs.webkit.org/attachment.cgi?id=183137&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183137&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:203
>	   this._contextSelector.addOption(option);

remove this line

> Source/WebCore/inspector/front-end/StatusBarButton.js:142
> +	       this.element.removeStyleClass("toggled-" + this._state);

Previously this was only done inside if clause. Why is it correct to take it
out?

> Source/WebCore/inspector/front-end/StatusBarButton.js:311
> +	   if (value !== "undefined")

typeof value !== ...