[webkit-reviews] review requested: [Bug 102901] Implement CSSValue::operator==() : [Attachment 183132] Patch 5

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 17 00:19:17 PST 2013


Alexander Shalamov <alexander.shalamov at gmail.com> has asked  for review:
Bug 102901: Implement CSSValue::operator==()
https://bugs.webkit.org/show_bug.cgi?id=102901

Attachment 183132: Patch 5
https://bugs.webkit.org/attachment.cgi?id=183132&action=review

------- Additional Comments from Alexander Shalamov
<alexander.shalamov at gmail.com>
Fixed patch according to Antti's comments:

- Renamed operator== to equals method
- Added template function to compare two RefPtrs that contain CSSValue objects
- Used early returns wherever possible
- Added layout test. Test creates stylesheet and then inserts html snippet with
inline style that duplicates style in document stylesheet. If inline style and
document style css property have equal cssvalues, inline style is removed from
inserted element.


More information about the webkit-reviews mailing list