[webkit-reviews] review granted: [Bug 107090] [TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer. : [Attachment 183114] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 107090: [TexMap] Match initializing members in GraphicsLayerTransform to
initializing members in GraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=107090

Attachment 183114: Patch
https://bugs.webkit.org/attachment.cgi?id=183114&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183114&action=review


This is pretty trivial so I would let it go in, but please be more explicit
about how it's tested.

> Source/WebCore/ChangeLog:13
> +	   Covered by existing variables tests.

Does this currently get reproduced?

> Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp:26
> +    : m_anchorPoint(0.5f, 0.5f, 0) // see m_anchorPoint initialization in
GraphicsLayer::GraphicsLayer().

You don't need f.
Also please remove the comment, if GraphicsLayer constructor is changed, it
will get stale.

> Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp:27
> +    , m_flattening(true) // see m_preserves3D initialization in
GraphicsLayer::GraphicsLayer().

Same here re. the comment.