[webkit-reviews] review granted: [Bug 107014] WebSpeech: implement voices list : [Attachment 183044] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 107014: WebSpeech: implement voices list
https://bugs.webkit.org/show_bug.cgi?id=107014

Attachment 183044: patch
https://bugs.webkit.org/attachment.cgi?id=183044&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183044&action=review


I don't read objective-c that well, but the objective-c code looks plausible. 
If you feel you need an objective-c expert, we might want to ask someone to
double-check that part of the patch.

> Source/WebCore/Modules/speech/mac/SpeechSynthesisMac.mm:56
> +	   RefPtr<SpeechSynthesisVoice> voice =
SpeechSynthesisVoice::create(voiceURI, name, language, true, isDefault);
> +	   m_voiceList.append(voice);

I would combine these lines both for readability and to save a ref churn.  You
can also save the ref churn by calling voice.release() on the last line.

> LayoutTests/platform/mac/TestExpectations:192
> +# Speech synthesis is not yet enabled.
> +platform/mac/fast/speechsynthesis

Should these tests be in platform/mac, or should they be in
fast/speechsynthesis outside the "mac" directory?  The test you wrote doesn't
seem particularly mac-specific.  (I realize this is going to make you edit a
bunch of other TestExpectations files, but it's probably the right thing to
do.)