[webkit-reviews] review granted: [Bug 106951] [chromium] Make new-style page scale work with fixed layout : [Attachment 183117] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 106951: [chromium] Make new-style page scale work with fixed layout
https://bugs.webkit.org/show_bug.cgi?id=106951

Attachment 183117: Patch
https://bugs.webkit.org/attachment.cgi?id=183117&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183117&action=review


I'm not able to verify every detail of this patch, but this definitely looks
like an improvement.

> Source/WebKit/chromium/ChangeLog:13
> +	   - dispatchViewportPropertiesDidChange() now works entirely with DIP
> +	   pixels instead of physical pixels, and is made compatible with
> +	   separating deviceScaleFactor from pageScaleFactor.

Great!