[webkit-reviews] review requested: [Bug 107091] Use xcrun to find path to make for Mac port : [Attachment 183113] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 21:08:34 PST 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 107091: Use xcrun to find path to make for Mac port
https://bugs.webkit.org/show_bug.cgi?id=107091

Attachment 183113: Patch
https://bugs.webkit.org/attachment.cgi?id=183113&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
<http://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add.  Tries to find a path for the make
command using xcrun.  Falls back to returning '/usr/bin/make'.

* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add.  Call xcrun_find().
(MacPort.nm_command): Use self.xcrun_find().
(MacPort.xcrun_find): Add.  Extract from nm_command().
---
 2 files changed, 29 insertions(+), 5 deletions(-)


More information about the webkit-reviews mailing list