[webkit-reviews] review denied: [Bug 107027] [Chromium] Route the Javascript scroll event to the layer tree. : [Attachment 182999] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 20:58:00 PST 2013


James Robinson <jamesr at chromium.org> has denied John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 107027: [Chromium] Route the Javascript scroll event to the layer tree.
https://bugs.webkit.org/show_bug.cgi?id=107027

Attachment 182999: Patch
https://bugs.webkit.org/attachment.cgi?id=182999&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182999&action=review


> Source/Platform/chromium/public/WebLayerTreeView.h:132
> +    // JavaScript has requested a scroll. Used to implement the
window.scrollTo(0,1) API to
> +    // hide the location bar.
> +    virtual void scrollFromJavaScript(const WebPoint& scrollPoint) = 0;

This doesn't really have anything to do with WebLayerTreeView or compositing. 
If you want a notification out to the embedder that a certain type of scroll
has happened, route it through the WebView or WebWidget family.  You can then
hook it up to whatever you want on the embedder side (aka chromium code)


More information about the webkit-reviews mailing list