[webkit-reviews] review requested: [Bug 39725] Dragging over an element with scrollbars should scroll the element when dragging near edges : [Attachment 183109] Patch-3.0.4

[bugzilla-daemon at webkit.org]

yosin at chromium.org has asked  for review:
Bug 39725: Dragging over an element with scrollbars should scroll the element
when dragging near edges
https://bugs.webkit.org/show_bug.cgi?id=39725

Attachment 183109: Patch-3.0.4
https://bugs.webkit.org/attachment.cgi?id=183109&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

= Changes since the last patch =
* Add skip entry for drag-and-drop-autoscroll.html into TestExpectations other
than Chromium ports.

= Changes since the last review =
* Mac compilation failure was fixed, unused parameter in
shouldAutoscrollForDragAndDrop() declaration.
* Style failure for VKEY_ESCAPE is a tool issue,
https://bugs.webkit.org/show_bug.cgi?id=106881

This patch fixes non-stopping autoscroll issue. The root cause is forgetting
call of stop autscroll timer at cancellation of drag-and-drop, e.g. pressing
ESCAPE key, drag off the window from another process's drag source.

= Changes since the last review =
* Call stopAutoscrollTimer() at EventHandler::clearDragState() which called
after drop or cancel of drag-and-drop.
* Introduce ChromeClient::shouldAutoscrollForDragAndDrop() for enabling
drag-and-drop autoscroll by each port rater than all ports. Note: Chromium port
enables.
* Layout test drag-and-drop-autosccroll.html checks stopping of autoscroll
after drag-and-drop cancellation.